CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't give shared pointer to obj. external to the model

Browse Source 
It causes some weird problems and adds refcounting overhead.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow
2022-08-11 18:24:26 -03:00
parent 97a74d5c1f
commit 92aa24ae34
10 changed files with 58 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
launcher/minecraft/mod/tasks/BasicFolderLoadTask.h
View File

@ -17,7 +17,7 @@ class BasicFolderLoadTask : public Task
Q_OBJECT
public:
struct Result {
QMap<QString, Resource::Ptr> resources;
QMap<QString, Resource*> resources;
};
using ResultPtr = std::shared_ptr<Result>;

2
launcher/minecraft/mod/tasks/ModFolderLoadTask.cpp
View File

@ -52,7 +52,7 @@ void ModFolderLoadTask::executeTask()
// Read JAR files that don't have metadata
m_mods_dir.refresh();
for (auto entry : m_mods_dir.entryInfoList()) {
Mod::Ptr mod(new Mod(entry));
Mod* mod(new Mod(entry));
if (mod->enabled()) {
if (m_result->mods.contains(mod->internal_id())) {