fix ftb import for old packs (#4787)

This commit is contained in:
Alexandru Ionut Tripon
2026-01-17 17:03:59 +02:00
committed by GitHub
2 changed files with 8 additions and 7 deletions

View File

@@ -80,7 +80,7 @@ Modpack parseDirectory(QString path)
const auto parts = modLoader.split('-', Qt::KeepEmptyParts);
if (parts.size() >= 2) {
const auto loader = parts.first().toLower();
modpack.version = parts.at(1).trimmed();
modpack.loaderVersion = parts.at(1).trimmed();
if (loader == "neoforge") {
modpack.loaderType = ModPlatform::NeoForge;
} else if (loader == "forge") {
@@ -91,13 +91,14 @@ Modpack parseDirectory(QString path)
modpack.loaderType = ModPlatform::Quilt;
}
}
} else {
legacyInstanceParsing(path, &modpack.loaderType, &modpack.loaderVersion);
}
} catch (const Exception& e) {
qDebug() << "Couldn't load ftb instance json: " << e.cause();
return {};
}
if (!modpack.loaderType.has_value()) {
legacyInstanceParsing(path, &modpack.loaderType, &modpack.loaderVersion);
}
auto iconFile = QFileInfo(FS::PathCombine(path, "folder.jpg"));
if (iconFile.exists() && iconFile.isFile()) {

View File

@@ -71,19 +71,19 @@ void PackInstallTask::copySettings()
if (modloader.has_value())
switch (modloader.value()) {
case ModPlatform::NeoForge: {
components->setComponentVersion("net.neoforged", m_pack.version, true);
components->setComponentVersion("net.neoforged", m_pack.loaderVersion, true);
break;
}
case ModPlatform::Forge: {
components->setComponentVersion("net.minecraftforge", m_pack.version, true);
components->setComponentVersion("net.minecraftforge", m_pack.loaderVersion, true);
break;
}
case ModPlatform::Fabric: {
components->setComponentVersion("net.fabricmc.fabric-loader", m_pack.version, true);
components->setComponentVersion("net.fabricmc.fabric-loader", m_pack.loaderVersion, true);
break;
}
case ModPlatform::Quilt: {
components->setComponentVersion("org.quiltmc.quilt-loader", m_pack.version, true);
components->setComponentVersion("org.quiltmc.quilt-loader", m_pack.loaderVersion, true);
break;
}
case ModPlatform::Cauldron: