CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use variables for string literals

Browse Source 
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com>
This commit is contained in:
Octol1ttle
2026-01-21 11:46:31 +05:00
parent ef747055af
commit 2842defe7f
1 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
launcher/minecraft/MinecraftInstance.cpp
View File

@@ -888,9 +888,13 @@ QString MinecraftInstance::createLaunchScript(AuthSessionPtr session, MinecraftT
QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, MinecraftTarget::Ptr targetToJoin)
{
constexpr auto indent = " ";
constexpr auto emptyLine = "";
QStringList out;
out << "Main Class:" << " " + getMainClass() << "";
out << "Native path:" << " " + getNativePath() << "";
out << "Main Class:" << indent + getMainClass() << emptyLine;
out << "Native path:" << indent + getNativePath() << emptyLine;
auto profile = m_components->getProfile();
@@ -899,9 +903,9 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
if (alltraits.size()) {
out << "Traits:";
for (auto trait : alltraits) {
out << "traits " + trait;
out << indent + trait;
}
out << "";
out << emptyLine;
}
// native libraries
@@ -913,7 +917,7 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
out << "Using system OpenAL.";
if (nativeGLFW)
out << "Using system GLFW.";
out << "";
out << emptyLine;
}
// libraries and class path.
@@ -924,20 +928,20 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
auto printLibFile = [&out](const QString& path) {
QFileInfo info(path);
if (info.exists()) {
out << " " + path;
out << indent + path;
} else {
out << " " + path + " (missing)";
out << indent + path + " (missing)";
}
};
for (auto file : jars) {
printLibFile(file);
}
out << "";
out << emptyLine;
out << "Native libraries:";
for (auto file : nativeJars) {
printLibFile(file);
}
out << "";
out << emptyLine;
}
// mods and core mods
@@ -962,7 +966,7 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
out << u8" [✘] " + mod->fileinfo().completeBaseName() + " (disabled)";
}
}
out << "";
out << emptyLine;
}
};
@@ -977,19 +981,19 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
auto displayname = jarmod->displayName(runtimeContext());
auto realname = jarmod->filename(runtimeContext());
if (displayname != realname) {
out << " " + displayname + " (" + realname + ")";
out << indent + displayname + " (" + realname + ")";
} else {
out << " " + realname;
out << indent + realname;
}
}
out << "";
out << emptyLine;
}
// minecraft arguments
auto params = processMinecraftArgs(nullptr, targetToJoin);
out << "Params:";
out << " " + params.join(' ');
out << "";
out << indent + params.join(' ');
out << emptyLine;
// window size
QString windowParams;
@@ -1000,9 +1004,10 @@ QStringList MinecraftInstance::verboseDescription(AuthSessionPtr session, Minecr
auto height = settings->get("MinecraftWinHeight").toInt();
out << "Window size: " + QString::number(width) + " x " + QString::number(height);
}
out << "";
out << emptyLine;
out << "Launcher: " + getLauncher();
out << "";
out << emptyLine;
return out;
}