fix(memory leak): don't override default deconstructor + reset shared_ptr + ensure modal get's cleaned up

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
2023-05-26 21:10:49 -07:00
parent aae892dfd1
commit ff03dd22fe
5 changed files with 3 additions and 7 deletions
--- a/launcher/ui/pages/modplatform/ResourceModel.cpp
+++ b/launcher/ui/pages/modplatform/ResourceModel.cpp
@ -230,7 +230,7 @@ void ResourceModel::clearData()

 void ResourceModel::runSearchJob(Task::Ptr ptr)
 {
-    m_current_search_job = ptr;
+    m_current_search_job.reset(ptr); // clean up first
    m_current_search_job->start();
 }
 void ResourceModel::runInfoJob(Task::Ptr ptr)