CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

NOISSUE rename MinecraftProfile to ComponentList

Browse Source 
It is realistically a list of components. The fact that it also holds the final
launch parameters is a design bug.
This commit is contained in:
Petr Mrázek
2017-10-11 23:04:24 +02:00
parent 87edaa7dcd
commit fede712a26
21 changed files with 120 additions and 120 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
api/logic/minecraft/MinecraftInstance.cpp
View File

@ -31,7 +31,7 @@
#include "icons/IIconList.h"
#include <QCoreApplication>
#include "MinecraftProfile.h"
#include "ComponentList.h"
#include "AssetsUtils.h"
#include "MinecraftUpdate.h"
@ -133,7 +133,7 @@ bool MinecraftInstance::reload()
void MinecraftInstance::createProfile()
{
m_profile.reset(new MinecraftProfile(this));
m_profile.reset(new ComponentList(this));
}
void MinecraftInstance::reloadProfile()
@ -149,14 +149,14 @@ void MinecraftInstance::clearProfile()
emit versionReloaded();
}
std::shared_ptr<MinecraftProfile> MinecraftInstance::getMinecraftProfile() const
std::shared_ptr<ComponentList> MinecraftInstance::getComponentList() const
{
return m_profile;
}
QSet<QString> MinecraftInstance::traits() const
{
auto version = getMinecraftProfile();
auto version = getComponentList();
if (!version)
{
return {"version-incomplete"};
@ -274,7 +274,7 @@ QStringList MinecraftInstance::getNativeJars() const
QStringList MinecraftInstance::extraArguments() const
{
auto list = BaseInstance::extraArguments();
auto version = getMinecraftProfile();
auto version = getComponentList();
if (!version)
return list;
auto jarMods = getJarMods();
@ -909,7 +909,7 @@ bool MinecraftInstance::setComponentVersion(const QString& uid, const QString& v
{
settings()->set("LiteloaderVersion", version);
}
if(getMinecraftProfile())
if(getComponentList())
{
clearProfile();
}