CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: TheKodeToad <TheKodeToad@proton.me>
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers 2023-08-01 18:53:51 -07:00 committed by GitHub
parent 5a9f780cf8
commit f19e8dd086
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
launcher/net/ApiHeaderProxy.h
View File

@ -27,7 +27,7 @@ namespace Net {
class ApiHeaderProxy : public HeaderProxy { class ApiHeaderProxy : public HeaderProxy {
public: public:
ApiHeaderProxy() : HeaderProxy(){}; ApiHeaderProxy() : HeaderProxy() {}
virtual ~ApiHeaderProxy() = default; virtual ~ApiHeaderProxy() = default;
public: public:

2
launcher/net/Download.h
View File

@ -48,7 +48,7 @@ class Download : public NetRequest {
Q_OBJECT Q_OBJECT
public: public:
using Ptr = shared_qobject_ptr<class Download>; using Ptr = shared_qobject_ptr<class Download>;
explicit Download() : NetRequest() { logCat = taskDownloadLogC; }; explicit Download() : NetRequest() { logCat = taskDownloadLogC; }
#if defined(LAUNCHER_APPLICATION) #if defined(LAUNCHER_APPLICATION)
static auto makeCached(QUrl url, MetaEntryPtr entry, Options options = Option::NoOptions) -> Download::Ptr; static auto makeCached(QUrl url, MetaEntryPtr entry, Options options = Option::NoOptions) -> Download::Ptr;

2
launcher/net/HeaderProxy.h
View File

@ -43,7 +43,7 @@ class HeaderProxy {
for (auto header : headers(request)) { for (auto header : headers(request)) {
request.setRawHeader(header.headerName, header.headerValue); request.setRawHeader(header.headerName, header.headerValue);
} }
}; }
}; };
} // namespace Net } // namespace Net

2
launcher/net/NetRequest.h
View File

@ -67,7 +67,7 @@ class NetRequest : public NetAction {
public: public:
void addValidator(Validator* v); void addValidator(Validator* v);
auto abort() -> bool override; auto abort() -> bool override;
auto canAbort() const -> bool override { return true; }; auto canAbort() const -> bool override { return true; }
private: private:
auto handleRedirect() -> bool; auto handleRedirect() -> bool;

2
launcher/net/RawHeaderProxy.h
View File

@ -27,7 +27,7 @@ namespace Net {
class RawHeaderProxy : public HeaderProxy { class RawHeaderProxy : public HeaderProxy {
public: public:
RawHeaderProxy() : HeaderProxy(){}; RawHeaderProxy() : HeaderProxy() {}
virtual ~RawHeaderProxy() = default; virtual ~RawHeaderProxy() = default;
public: public: