some further cleanup, following some Clang-Tidy suggestions and CodeQL

Signed-off-by: Tayou <tayou@gmx.net>
This commit is contained in:
Tayou
2023-05-19 21:21:15 +02:00
committed by Tayou
parent 8a6c0e7314
commit e90706461c
3 changed files with 32 additions and 38 deletions

View File

@ -38,6 +38,7 @@ GameOptionWidgetKeyBind::~GameOptionWidgetKeyBind()
}
void GameOptionWidgetKeyBind::setEditorData(GameOptionItem optionItem) {
// TODO implement this, *keybindingOptions is needed
/*for (auto& keyBinding : *keybindingOptions) {
// this could become a std::find_if eventually, if someone wants to bother making it that.
if (keyBinding->minecraftKeyCode == contents[row].knownOption->getDefaultString()) {
@ -50,6 +51,7 @@ void GameOptionWidgetKeyBind::setEditorData(GameOptionItem optionItem) {
}
void GameOptionWidgetKeyBind::saveEditorData(GameOptionItem optionItem) {
QString minecraftKeyCode;
// TODO implement this, *keybindingOptions is needed
/*for (auto& keyBinding : *keybindingOptions) {
// this could become a std::find_if eventually, if someone wants to bother making it that.
if (keyBinding->qtKeyCode.keyboardKey == ui->keySequenceEdit->keySequence()[0].key() ||