Merge pull request #808 from Scrumplex/fix-lgtm-warnings

2022-07-09 01:10:59 +02:00
parent 35a698ef72 9ec260619b
commit e6fe701727
8 changed files with 20 additions and 11 deletions
--- a/launcher/minecraft/auth/AccountTask.cpp
+++ b/launcher/minecraft/auth/AccountTask.cpp
@ -79,6 +79,8 @@ QString AccountTask::getStateMessage() const
 bool AccountTask::changeState(AccountTaskState newState, QString reason)
 {
    m_taskState = newState;
+    // FIXME: virtual method invoked in constructor.
+    // We want that behavior, but maybe make it less weird?
    setStatus(getStateMessage());
    switch(newState) {
        case AccountTaskState::STATE_CREATED: {