From d7d2d9f6123618273f753fd07263c807112031d2 Mon Sep 17 00:00:00 2001
From: Rachel Powers <508861+Ryex@users.noreply.github.com>
Date: Fri, 30 Jun 2023 23:17:18 -0700
Subject: [PATCH] chore: remove WARNINGS_AS_ERRORS

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
---
 cmake/CompilerWarnings.cmake | 9 ---------
 launcher/CMakeLists.txt      | 2 --
 2 files changed, 11 deletions(-)

diff --git a/cmake/CompilerWarnings.cmake b/cmake/CompilerWarnings.cmake
index b03664016..635e54289 100644
--- a/cmake/CompilerWarnings.cmake
+++ b/cmake/CompilerWarnings.cmake
@@ -39,7 +39,6 @@ endfunction()
 function(
   set_project_warnings
   _project_name
-  WARNINGS_AS_ERRORS
   MSVC_WARNINGS
   CLANG_WARNINGS
   GCC_WARNINGS
@@ -105,14 +104,6 @@ function(
     )
   endif()
 
-  
-  if(WARNINGS_AS_ERRORS)
-    message(TRACE "Warnings are treated as errors")
-    list(APPEND CLANG_WARNINGS -Werror)
-    list(APPEND GCC_WARNINGS -Werror)
-    list(APPEND MSVC_WARNINGS /WX)
-  endif()
-
   if(MSVC)
     set(PROJECT_WARNINGS_CXX ${MSVC_WARNINGS})
   elseif(CMAKE_CXX_COMPILER_ID MATCHES ".*Clang")
diff --git a/launcher/CMakeLists.txt b/launcher/CMakeLists.txt
index 9bb465721..b3071ae24 100644
--- a/launcher/CMakeLists.txt
+++ b/launcher/CMakeLists.txt
@@ -1095,7 +1095,6 @@ include(CompilerWarnings)
 # Add executable
 add_library(Launcher_logic STATIC ${LOGIC_SOURCES} ${LAUNCHER_SOURCES} ${LAUNCHER_UI} ${LAUNCHER_RESOURCES})
 set_project_warnings(Launcher_logic
-    "${WARNINGS_AS_ERRORS}"
     "${Launcher_MSVC_WARNINGS}"
     "${Launcher_CLANG_WARNINGS}"
     "${Launcher_GCC_WARNINGS}")
@@ -1178,7 +1177,6 @@ install(TARGETS ${Launcher_Name}
 if(WIN32)
     add_library(filelink_logic STATIC ${LINKEXE_SOURCES})
     set_project_warnings(filelink_logic
-    "${WARNINGS_AS_ERRORS}"
     "${Launcher_MSVC_WARNINGS}"
     "${Launcher_CLANG_WARNINGS}"
     "${Launcher_GCC_WARNINGS}")