CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use isEmpty instead of size for lists

Browse Source 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
This commit is contained in:
Sefa Eyeoglu 2022-11-16 23:20:31 +01:00
parent 40970a1a87
commit ce958f4ffd
No known key found for this signature in database
GPG Key ID: C10411294912A422
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
launcher/minecraft/MojangVersionFormat.cpp
View File

@ -135,7 +135,7 @@ QJsonObject libDownloadInfoToJson(MojangLibraryDownloadInfo::Ptr libinfo)
{ {
out.insert("artifact", downloadInfoToJson(libinfo->artifact)); out.insert("artifact", downloadInfoToJson(libinfo->artifact));
} }
if(libinfo->classifiers.size()) if(!libinfo->classifiers.isEmpty())
{ {
QJsonObject classifiersOut; QJsonObject classifiersOut;
for(auto iter = libinfo->classifiers.begin(); iter != libinfo->classifiers.end(); iter++) for(auto iter = libinfo->classifiers.begin(); iter != libinfo->classifiers.end(); iter++)
@ -297,7 +297,7 @@ void MojangVersionFormat::writeVersionProperties(const VersionFile* in, QJsonObj
{ {
out.insert("assetIndex", assetIndexToJson(in->mojangAssetIndex)); out.insert("assetIndex", assetIndexToJson(in->mojangAssetIndex));
} }
if(in->mojangDownloads.size()) if(!in->mojangDownloads.isEmpty())
{ {
QJsonObject downloadsOut; QJsonObject downloadsOut;
for(auto iter = in->mojangDownloads.begin(); iter != in->mojangDownloads.end(); iter++) for(auto iter = in->mojangDownloads.begin(); iter != in->mojangDownloads.end(); iter++)
@ -306,7 +306,7 @@ void MojangVersionFormat::writeVersionProperties(const VersionFile* in, QJsonObj
} }
out.insert("downloads", downloadsOut); out.insert("downloads", downloadsOut);
} }
if(in->compatibleJavaMajors.size()) if(!in->compatibleJavaMajors.isEmpty())
{ {
QJsonArray compatibleJavaMajorsOut; QJsonArray compatibleJavaMajorsOut;
for(auto compatibleJavaMajor : in->compatibleJavaMajors) for(auto compatibleJavaMajor : in->compatibleJavaMajors)
@ -405,7 +405,7 @@ QJsonObject MojangVersionFormat::libraryToJson(Library *library)
iter++; iter++;
} }
libRoot.insert("natives", nativeList); libRoot.insert("natives", nativeList);
if (library->m_extractExcludes.size()) if (!library->m_extractExcludes.isEmpty())
{ {
QJsonArray excludes; QJsonArray excludes;
QJsonObject extract; QJsonObject extract;
@ -417,7 +417,7 @@ QJsonObject MojangVersionFormat::libraryToJson(Library *library)
libRoot.insert("extract", extract); libRoot.insert("extract", extract);
} }
} }
if (library->m_rules.size()) if (!library->m_rules.isEmpty())
{ {
QJsonArray allRules; QJsonArray allRules;
for (auto &rule : library->m_rules) for (auto &rule : library->m_rules)

8
launcher/minecraft/OneSixVersionFormat.cpp
View File

@ -63,13 +63,13 @@ LibraryPtr OneSixVersionFormat::libraryFromJson(ProblemContainer & problems, con
QJsonObject OneSixVersionFormat::libraryToJson(Library *library) QJsonObject OneSixVersionFormat::libraryToJson(Library *library)
{ {
QJsonObject libRoot = MojangVersionFormat::libraryToJson(library); QJsonObject libRoot = MojangVersionFormat::libraryToJson(library);
if (library->m_absoluteURL.size()) if (!library->m_absoluteURL.isEmpty())
libRoot.insert("MMC-absoluteUrl", library->m_absoluteURL); libRoot.insert("MMC-absoluteUrl", library->m_absoluteURL);
if (library->m_hint.size()) if (!library->m_hint.isEmpty())
libRoot.insert("MMC-hint", library->m_hint); libRoot.insert("MMC-hint", library->m_hint);
if (library->m_filename.size()) if (!library->m_filename.isEmpty())
libRoot.insert("MMC-filename", library->m_filename); libRoot.insert("MMC-filename", library->m_filename);
if (library->m_displayname.size()) if (!library->m_displayname.isEmpty())
libRoot.insert("MMC-displayname", library->m_displayname); libRoot.insert("MMC-displayname", library->m_displayname);
return libRoot; return libRoot;
} }