chore: clean up after new compiler warnings

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers
2023-06-04 14:59:37 -07:00
parent 7e0e1ec51d
commit cc41b039e6
25 changed files with 74 additions and 78 deletions

View File

@ -32,7 +32,7 @@ class DummyResourceAPI : public ResourceAPI {
}
DummyResourceAPI() : ResourceAPI() {}
[[nodiscard]] auto getSortingMethods() const -> QList<SortingMethod> override { return {}; };
[[nodiscard]] auto getSortingMethods() const -> QList<SortingMethod> override { return {}; }
[[nodiscard]] Task::Ptr searchProjects(SearchArgs&&, SearchCallbacks&& callbacks) const override
{

View File

@ -91,10 +91,9 @@ class LinkTask : public Task {
emitSucceeded();
}
};
}
FS::create_link *m_lnk;
bool m_useHard = false;
bool m_linkRecursive = true;
};
@ -346,7 +345,7 @@ slots:
void test_link()
{
QString folder = QFINDTESTDATA("testdata/FileSystem/test_folder");
auto f = [&folder, this]()
auto f = [&folder]()
{
QTemporaryDir tempDir;
tempDir.setAutoRemove(true);
@ -640,7 +639,7 @@ slots:
void test_link_with_max_depth()
{
QString folder = QFINDTESTDATA("testdata/FileSystem/test_folder");
auto f = [&folder, this]()
auto f = [&folder]()
{
QTemporaryDir tempDir;
tempDir.setAutoRemove(true);

View File

@ -29,7 +29,7 @@ slots:
// initialize random buffer
for(int i = 0; i < size; i++)
{
random.append((char)idis(eng));
random.append(static_cast<char>(idis(eng)));
}
// initialize fibonacci

View File

@ -39,17 +39,17 @@ class DummyResourceModel : public ResourceModel {
public:
DummyResourceModel() : ResourceModel(new DummyResourceAPI) {}
[[nodiscard]] auto metaEntryBase() const -> QString override { return ""; };
[[nodiscard]] auto metaEntryBase() const -> QString override { return ""; }
ResourceAPI::SearchArgs createSearchArguments() override { return {}; };
ResourceAPI::VersionSearchArgs createVersionsArguments(QModelIndex&) override { return {}; };
ResourceAPI::ProjectInfoArgs createInfoArguments(QModelIndex&) override { return {}; };
ResourceAPI::SearchArgs createSearchArguments() override { return {}; }
ResourceAPI::VersionSearchArgs createVersionsArguments(QModelIndex&) override { return {}; }
ResourceAPI::ProjectInfoArgs createInfoArguments(QModelIndex&) override { return {}; }
QJsonArray documentToArray(QJsonDocument& doc) const override { return doc.object().value("hits").toArray(); }
void loadIndexedPack(ModPlatform::IndexedPack& pack, QJsonObject& obj) override
{
pack.authors.append({ Json::requireString(obj, "author") });
pack.authors.append({ Json::requireString(obj, "author"), "" });
pack.description = Json::requireString(obj, "description");
pack.addonId = Json::requireString(obj, "project_id");
}

View File

@ -22,7 +22,7 @@ class BasicTask : public Task {
void executeTask() override
{
emitSucceeded();
};
}
};
/* Does nothing. Only used for testing. */
@ -34,7 +34,7 @@ class BasicTask_MultiStep : public Task {
private:
auto isMultiStep() const -> bool override { return true; }
void executeTask() override {};
void executeTask() override {}
};
class BigConcurrentTask : public ConcurrentTask {