CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

GH-1178 add failing test

Browse Source
This commit is contained in:
Petr Mrázek 2015-12-26 03:13:31 +01:00
parent 243c5d1cfb
commit c64a7940c1
3 changed files with 53 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
logic/minecraft/ModList.cpp
View File

@ -575,7 +575,6 @@ bool ModList::dropMimeData(const QMimeData *data, Qt::DropAction action, int row
if (!url.isLocalFile()) if (!url.isLocalFile())
continue; continue;
QString filename = url.toLocalFile(); QString filename = url.toLocalFile();
qDebug() << "installing: " << filename;
installMod(filename, row); installMod(filename, row);
// if there is no ordering, re-sort the list // if there is no ordering, re-sort the list
if (m_list_file.isEmpty()) if (m_list_file.isEmpty())

1
tests/CMakeLists.txt
View File

@ -27,6 +27,7 @@ add_unit_test(FileSystem tst_FileSystem.cpp)
add_unit_test(UpdateChecker tst_UpdateChecker.cpp) add_unit_test(UpdateChecker tst_UpdateChecker.cpp)
add_unit_test(DownloadTask tst_DownloadTask.cpp) add_unit_test(DownloadTask tst_DownloadTask.cpp)
add_unit_test(filematchers tst_filematchers.cpp) add_unit_test(filematchers tst_filematchers.cpp)
add_unit_test(ModList tst_ModList.cpp)
add_unit_test(Resource tst_Resource.cpp) add_unit_test(Resource tst_Resource.cpp)
add_unit_test(GZip tst_GZip.cpp) add_unit_test(GZip tst_GZip.cpp)

52
tests/tst_ModList.cpp Normal file
View File

@ -0,0 +1,52 @@
#include <QTest>
#include "TestUtil.h"
#include "FileSystem.h"
#include "minecraft/ModList.h"
class ModListTest : public QObject
{
Q_OBJECT
private
slots:
// test for GH-1178 - install a folder with files to a mod list
void test_1178()
{
// source
QString source = QFINDTESTDATA("tests/data/test_folder");
// sanity check
QVERIFY(!source.endsWith('/'));
auto verify = [](QString path)
{
QDir target_dir(FS::PathCombine(path, "test_folder"));
QVERIFY(target_dir.entryList().contains("pack.mcmeta"));
QVERIFY(target_dir.entryList().contains("assets"));
};
// 1. test with no trailing /
{
QString folder = source;
QTemporaryDir tempDir;
ModList m(tempDir.path());
m.installMod(folder);
verify(tempDir.path());
}
// 2. test with trailing /
{
QString folder = source + '/';
QTemporaryDir tempDir;
ModList m(tempDir.path());
m.installMod(folder);
verify(tempDir.path());
}
}
};
QTEST_GUILESS_MAIN(ModListTest)
#include "tst_ModList.moc"