GH-1003 Fix settings dialog delays
This commit is contained in:
@ -1382,8 +1382,11 @@ void ShowPageDialog(T raw_provider, QWidget * parent, QString open_page = QStrin
|
||||
auto provider = std::dynamic_pointer_cast<BasePageProvider>(raw_provider);
|
||||
if(!provider)
|
||||
return;
|
||||
PageDialog dlg(provider, open_page, parent);
|
||||
dlg.exec();
|
||||
{
|
||||
SettingsObject::Lock lock(MMC->settings());
|
||||
PageDialog dlg(provider, open_page, parent);
|
||||
dlg.exec();
|
||||
}
|
||||
}
|
||||
|
||||
void ShowInstancePageDialog(InstancePtr instance, QWidget * parent, QString open_page = QString())
|
||||
|
@ -62,8 +62,6 @@ void ExternalToolsPage::applySettings()
|
||||
{
|
||||
auto s = MMC->settings();
|
||||
|
||||
SettingsObject::Lock lock(s);
|
||||
|
||||
s->set("JProfilerPath", ui->jprofilerPathEdit->text());
|
||||
s->set("JVisualVMPath", ui->jvisualvmPathEdit->text());
|
||||
s->set("MCEditPath", ui->mceditPathEdit->text());
|
||||
|
@ -59,8 +59,6 @@ void JavaPage::applySettings()
|
||||
{
|
||||
auto s = MMC->settings();
|
||||
|
||||
SettingsObject::Lock lock(s);
|
||||
|
||||
// Memory
|
||||
s->set("MinMemAlloc", ui->minMemSpinBox->value());
|
||||
s->set("MaxMemAlloc", ui->maxMemSpinBox->value());
|
||||
|
@ -62,8 +62,6 @@ void MinecraftPage::applySettings()
|
||||
{
|
||||
auto s = MMC->settings();
|
||||
|
||||
SettingsObject::Lock lock(s);
|
||||
|
||||
// Window Size
|
||||
s->set("LaunchMaximized", ui->maximizedCheckBox->isChecked());
|
||||
s->set("MinecraftWinWidth", ui->windowWidthSpinBox->value());
|
||||
|
@ -248,8 +248,6 @@ void MultiMCPage::applySettings()
|
||||
{
|
||||
auto s = MMC->settings();
|
||||
|
||||
SettingsObject::Lock lock(s);
|
||||
|
||||
// Language
|
||||
s->set("Language",
|
||||
ui->languageBox->itemData(ui->languageBox->currentIndex()).toLocale().bcp47Name());
|
||||
|
@ -57,8 +57,6 @@ void ProxyPage::applySettings()
|
||||
{
|
||||
auto s = MMC->settings();
|
||||
|
||||
SettingsObject::Lock lock(s);
|
||||
|
||||
// Proxy
|
||||
QString proxyType = "None";
|
||||
if (ui->proxyDefaultBtn->isChecked())
|
||||
|
Reference in New Issue
Block a user