From b07c5982e115befaec91a3919dafc9e6ec467f24 Mon Sep 17 00:00:00 2001
From: Sefa Eyeoglu <contact@scrumplex.net>
Date: Sun, 29 May 2022 12:46:44 +0200
Subject: [PATCH] fix: set version for Windows binaries

---
 CMakeLists.txt                                       | 2 ++
 launcher/CMakeLists.txt                              | 2 +-
 program_info/CMakeLists.txt                          | 3 +++
 program_info/{polymc.manifest => polymc.manifest.in} | 2 +-
 program_info/{polymc.rc => polymc.rc.in}             | 6 +++---
 5 files changed, 10 insertions(+), 5 deletions(-)
 rename program_info/{polymc.manifest => polymc.manifest.in} (97%)
 rename program_info/{polymc.rc => polymc.rc.in} (76%)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index fcc2512d8..31b2f23be 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -128,6 +128,8 @@ message(STATUS "Git commit: ${Launcher_GIT_COMMIT}")
 message(STATUS "Git refspec: ${Launcher_GIT_REFSPEC}")
 
 set(Launcher_RELEASE_VERSION_NAME "${Launcher_VERSION_MAJOR}.${Launcher_VERSION_MINOR}.${Launcher_VERSION_HOTFIX}")
+set(Launcher_RELEASE_VERSION_NAME4 "${Launcher_RELEASE_VERSION_NAME}.0")
+set(Launcher_RELEASE_VERSION_NAME4_COMMA "${Launcher_VERSION_MAJOR},${Launcher_VERSION_MINOR},${Launcher_VERSION_HOTFIX},0")
 string(TIMESTAMP TODAY "%Y-%m-%d")
 set(Launcher_RELEASE_TIMESTAMP "${TODAY}")
 
diff --git a/launcher/CMakeLists.txt b/launcher/CMakeLists.txt
index b3af12a67..bbf801854 100644
--- a/launcher/CMakeLists.txt
+++ b/launcher/CMakeLists.txt
@@ -963,7 +963,7 @@ qt5_add_resources(LAUNCHER_RESOURCES
 
 ######## Windows resource files ########
 if(WIN32)
-    set(LAUNCHER_RCS ../${Launcher_Branding_WindowsRC})
+    set(LAUNCHER_RCS ${CMAKE_CURRENT_BINARY_DIR}/../${Launcher_Branding_WindowsRC})
 endif()
 
 # Add executable
diff --git a/program_info/CMakeLists.txt b/program_info/CMakeLists.txt
index 60549d8d3..2cbef1b61 100644
--- a/program_info/CMakeLists.txt
+++ b/program_info/CMakeLists.txt
@@ -21,3 +21,6 @@ set(Launcher_Portable_File "program_info/portable.txt" PARENT_SCOPE)
 
 configure_file(org.polymc.PolyMC.desktop.in org.polymc.PolyMC.desktop)
 configure_file(org.polymc.PolyMC.metainfo.xml.in org.polymc.PolyMC.metainfo.xml)
+configure_file(polymc.rc.in polymc.rc @ONLY)
+configure_file(polymc.manifest.in polymc.manifest @ONLY)
+configure_file(polymc.ico polymc.ico COPYONLY)
diff --git a/program_info/polymc.manifest b/program_info/polymc.manifest.in
similarity index 97%
rename from program_info/polymc.manifest
rename to program_info/polymc.manifest.in
index 8ca50acf4..0eefacacd 100644
--- a/program_info/polymc.manifest
+++ b/program_info/polymc.manifest.in
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
-  <assemblyIdentity name="PolyMC.Application.1" type="win32" version="1.0.0.0" />
+  <assemblyIdentity name="PolyMC.Application.1" type="win32" version="@Launcher_RELEASE_VERSION_NAME4@" />
   <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
     <security>
       <requestedPrivileges>
diff --git a/program_info/polymc.rc b/program_info/polymc.rc.in
similarity index 76%
rename from program_info/polymc.rc
rename to program_info/polymc.rc.in
index 011e944b9..0ea9b73a0 100644
--- a/program_info/polymc.rc
+++ b/program_info/polymc.rc.in
@@ -7,7 +7,7 @@ IDI_ICON1               ICON    DISCARDABLE     "polymc.ico"
 1 RT_MANIFEST "polymc.manifest"
 
 VS_VERSION_INFO VERSIONINFO
-FILEVERSION     1,0,0,0
+FILEVERSION     @Launcher_RELEASE_VERSION_NAME4_COMMA@
 FILEOS          VOS_NT_WINDOWS32
 FILETYPE        VFT_APP
 BEGIN
@@ -17,9 +17,9 @@ BEGIN
                 BEGIN
                         VALUE "CompanyName", "MultiMC & PolyMC Contributors"
                         VALUE "FileDescription", "PolyMC"
-                        VALUE "FileVersion", "1.0.0.0"
+                        VALUE "FileVersion", "@Launcher_RELEASE_VERSION_NAME4@"
                         VALUE "ProductName", "PolyMC"
-                        VALUE "ProductVersion", "1"
+                        VALUE "ProductVersion", "@Launcher_RELEASE_VERSION_NAME4@"
                 END
         END
         BLOCK "VarFileInfo"