CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #804 from flowln/improve_big_concurrent_task_test

Browse Source
This commit is contained in:
flow 2023-02-02 13:47:51 -08:00 committed by Sefa Eyeoglu
parent 68c884f20d
commit a7ff74365d
No known key found for this signature in database
GPG Key ID: E13DFD4B47127951
1 changed files with 23 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
tests/Task_test.cpp
View File

@ -7,6 +7,8 @@
#include <tasks/SequentialTask.h> #include <tasks/SequentialTask.h>
#include <tasks/Task.h> #include <tasks/Task.h>
#include <array>
/* Does nothing. Only used for testing. */ /* Does nothing. Only used for testing. */
class BasicTask : public Task { class BasicTask : public Task {
Q_OBJECT Q_OBJECT
@ -35,10 +37,23 @@ class BasicTask_MultiStep : public Task {
void executeTask() override {}; void executeTask() override {};
}; };
class BigConcurrentTask : public QThread { class BigConcurrentTask : public ConcurrentTask {
Q_OBJECT Q_OBJECT
ConcurrentTask big_task; void startNext() override
{
// This is here only to help fill the stack a bit more quickly (if there's an issue, of course :^))
// Each tasks thus adds 1024 * 4 bytes to the stack, at the very least.
[[maybe_unused]] volatile std::array<uint32_t, 1024> some_data_on_the_stack {};
ConcurrentTask::startNext();
}
};
class BigConcurrentTaskThread : public QThread {
Q_OBJECT
BigConcurrentTask big_task;
void run() override void run() override
{ {
@ -48,8 +63,10 @@ class BigConcurrentTask : public QThread {
deadline.start(); deadline.start();
// NOTE: Arbitrary value that manages to trigger a problem when there is one. // NOTE: Arbitrary value that manages to trigger a problem when there is one.
static const unsigned s_num_tasks = 1 << 14; // Considering each tasks, in a problematic state, adds 1024 * 4 bytes to the stack,
auto sub_tasks = new BasicTask*[s_num_tasks]; // this number is enough to fill up 16 MiB of stack, more than enough to cause a problem.
static const unsigned s_num_tasks = 1 << 12;
auto sub_tasks = new BasicTask::Ptr[s_num_tasks];
for (unsigned i = 0; i < s_num_tasks; i++) { for (unsigned i = 0; i < s_num_tasks; i++) {
sub_tasks[i] = new BasicTask(false); sub_tasks[i] = new BasicTask(false);
@ -229,12 +246,9 @@ class TaskTest : public QObject {
{ {
QEventLoop loop; QEventLoop loop;
auto thread = new BigConcurrentTask; auto thread = new BigConcurrentTaskThread;
// NOTE: This is an arbitrary value, big enough to not cause problems on normal execution, but low enough
// so that the number of tasks that needs to get ran to potentially cause a problem isn't too big.
thread->setStackSize(32 * 1024);
connect(thread, &BigConcurrentTask::finished, &loop, &QEventLoop::quit); connect(thread, &BigConcurrentTaskThread::finished, &loop, &QEventLoop::quit);
thread->start(); thread->start();