CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: fix warnings reported by LGTM.com

Browse Source
This commit is contained in:
Sefa Eyeoglu
2022-06-17 16:34:32 +02:00
parent 03e454b71d
commit 9ec260619b
8 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
launcher/minecraft/auth/AccountTask.cpp
View File

@ -79,6 +79,8 @@ QString AccountTask::getStateMessage() const
bool AccountTask::changeState(AccountTaskState newState, QString reason)
{
m_taskState = newState;
// FIXME: virtual method invoked in constructor.
// We want that behavior, but maybe make it less weird?
setStatus(getStateMessage());
switch(newState) {
case AccountTaskState::STATE_CREATED: {

2
launcher/modplatform/flame/FlameAPI.h
View File

@ -59,7 +59,7 @@ class FlameAPI : public NetworkModAPI {
};
public:
static auto getMappedModLoader(const ModLoaderTypes loaders) -> const int
static auto getMappedModLoader(const ModLoaderTypes loaders) -> int
{
// https://docs.curseforge.com/?http#tocS_ModLoaderType
if (loaders & Forge)

5
launcher/translations/POTranslator.cpp
View File

@ -329,6 +329,11 @@ POTranslator::POTranslator(const QString& filename, QObject* parent) : QTranslat
d->reload();
}
POTranslator::~POTranslator()
{
delete d;
}
QString POTranslator::translate(const char* context, const char* sourceText, const char* disambiguation, int n) const
{
if(disambiguation)

1
launcher/translations/POTranslator.h
View File

@ -9,6 +9,7 @@ class POTranslator : public QTranslator
Q_OBJECT
public:
explicit POTranslator(const QString& filename, QObject * parent = nullptr);
virtual ~POTranslator();
QString translate(const char * context, const char * sourceText, const char * disambiguation, int n) const override;
bool isEmpty() const override;
private: