CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't give shared pointer to obj. external to the model

Browse Source 
It causes some weird problems and adds refcounting overhead.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow
2022-08-11 18:24:26 -03:00
parent 97a74d5c1f
commit 92aa24ae34
10 changed files with 58 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
launcher/minecraft/mod/ModFolderModel.cpp
View File

@ -226,9 +226,9 @@ bool ModFolderModel::stopWatching()
return ResourceFolderModel::stopWatching({ m_dir.absolutePath(), indexDir().absolutePath() });
}
auto ModFolderModel::selectedMods(QModelIndexList& indexes) -> QList<Mod::Ptr>
auto ModFolderModel::selectedMods(QModelIndexList& indexes) -> QList<Mod*>
{
QList<Mod::Ptr> selected_resources;
QList<Mod*> selected_resources;
for (auto i : indexes) {
if(i.column() != 0)
continue;
@ -238,12 +238,13 @@ auto ModFolderModel::selectedMods(QModelIndexList& indexes) -> QList<Mod::Ptr>
return selected_resources;
}
auto ModFolderModel::allMods() -> QList<Mod::Ptr>
auto ModFolderModel::allMods() -> QList<Mod*>
{
QList<Mod::Ptr> mods;
QList<Mod*> mods;
for (auto res : m_resources)
for (auto& res : m_resources) {
mods.append(static_cast<Mod*>(res.get()));
}
return mods;
}