CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Try to improve consistency

Browse Source 
- Makes code formatting more consistent with the C++ codebase. Probably removes some trailing whitespace. Maybe it would be best to commit an Eclipse or IntelliJ code format preferences file?
- Removes obscure suppressions. I personally think it's better to only suppress warnings that javac complains about. Suppressing a lot of non-standardised warnings (many of them turned off by default even in IntelliJ) just creates needless clutter.
- Fixes some trivial warnings instead of suppressing them. serialVersionUID is sort of stupid, but I'd rather mentally ignore it or just fix it if it's really that annoying.

Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
This commit is contained in:
TheKodeToad
2022-11-03 16:40:23 +00:00
parent afe088dba1
commit 8ce78dcc54
11 changed files with 40 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
libraries/launcher/org/prismlauncher/exception/ParameterNotFoundException.java
View File

@ -5,6 +5,8 @@
* Copyright (C) 2022 icelimetea <fr3shtea@outlook.com>
* Copyright (C) 2022 Sefa Eyeoglu <contact@scrumplex.net>
* Copyright (C) 2022 Samisafool <thenerdiestguy@gmail.com>
* Copyright (C) 2022 solonovamax <solonovamax@12oclockpoint.com>
* Copyright (C) 2022 TheKodeToad <TheKodeToad@proton.me>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -38,10 +40,10 @@
package org.prismlauncher.exception;
@SuppressWarnings("serial")
public final class ParameterNotFoundException extends IllegalArgumentException {
private static final long serialVersionUID = 1L;
public ParameterNotFoundException(String message, Throwable cause) {
super(message, cause);
}
@ -55,7 +57,6 @@ public final class ParameterNotFoundException extends IllegalArgumentException {
}
public ParameterNotFoundException() {
super();
}
public static ParameterNotFoundException forParameterName(String parameterName) {

7
libraries/launcher/org/prismlauncher/exception/ParseException.java
View File

@ -5,6 +5,8 @@
* Copyright (C) 2022 icelimetea <fr3shtea@outlook.com>
* Copyright (C) 2022 Sefa Eyeoglu <contact@scrumplex.net>
* Copyright (C) 2022 Samisafool <thenerdiestguy@gmail.com>
* Copyright (C) 2022 solonovamax <solonovamax@12oclockpoint.com>
* Copyright (C) 2022 TheKodeToad <TheKodeToad@proton.me>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@ -38,10 +40,10 @@
package org.prismlauncher.exception;
@SuppressWarnings({ "serial", "unused" })
public final class ParseException extends IllegalArgumentException {
private static final long serialVersionUID = 1L;
public ParseException(String message) {
super(message);
}
@ -65,4 +67,5 @@ public final class ParseException extends IllegalArgumentException {
public static ParseException forInputString(String inputString, Throwable cause) {
return new ParseException(String.format("Could not parse input string '%s'", inputString), cause);
}
}