CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Handle a bunch more clang warnings

Browse Source
This commit is contained in:
Petr Mrázek
2014-07-01 01:23:49 +02:00
parent dd0752e69f
commit 8b86306d48
14 changed files with 19 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
gui/dialogs/IconPickerDialog.h
View File

@ -29,7 +29,10 @@ class IconPickerDialog : public QDialog
public:
explicit IconPickerDialog(QWidget *parent = 0);
~IconPickerDialog();
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Woverloaded-virtual"
int exec(QString selection);
#pragma clang diagnostic pop
QString selectedIconKey;
protected:

4
gui/dialogs/ProgressDialog.h
View File

@ -34,7 +34,11 @@ public:
void updateSize();
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Woverloaded-virtual"
int exec(ProgressProvider *task);
#pragma clang diagnostic pop
void setSkipButton(bool present, QString label = QString());
ProgressProvider *getTask();

2
gui/pages/ScreenshotsPage.h
View File

@ -27,7 +27,7 @@ namespace Ui
class ScreenshotsPage;
}
class ScreenShot;
struct ScreenShot;
class ScreenshotList;
class ImgurAlbumCreation;

6
gui/pages/VersionPage.cpp
View File

@ -214,10 +214,7 @@ void VersionPage::on_moveLibraryUpBtn_clicked()
try
{
const int row = ui->libraryTreeView->selectionModel()->selectedRows().first().row();
const int newRow = 0;
m_version->move(row, InstanceVersion::MoveUp);
// ui->libraryTreeView->selectionModel()->setCurrentIndex(m_version->index(newRow),
// QItemSelectionModel::ClearAndSelect);
}
catch (MMCError &e)
{
@ -234,10 +231,7 @@ void VersionPage::on_moveLibraryDownBtn_clicked()
try
{
const int row = ui->libraryTreeView->selectionModel()->selectedRows().first().row();
const int newRow = 0;
m_version->move(row, InstanceVersion::MoveDown);
// ui->libraryTreeView->selectionModel()->setCurrentIndex(m_version->index(newRow),
// QItemSelectionModel::ClearAndSelect);
}
catch (MMCError &e)
{