Automatically add add-opens if Java version >= 9

Signed-off-by: TheKodeToad <TheKodeToad@proton.me>

launcher/java/JavaVersion.cpp

@@ -50,11 +50,11 @@ QString JavaVersion::toString()
 
 bool JavaVersion::requiresPermGen()
 {
-    if(m_parseable)
-    {
-        return m_major < 8;
-    }
-    return true;
+    return !m_parseable || m_major < 8;
+}
+
+bool JavaVersion::isModular() {
+    return m_parseable && m_major >= 9;
 }
 
 bool JavaVersion::operator<(const JavaVersion &rhs)

launcher/java/JavaVersion.h

@@ -25,6 +25,8 @@ public:
 
     bool requiresPermGen();
 
+    bool isModular();
+
     QString toString();
 
     int major()

launcher/minecraft/MinecraftInstance.cpp

@@ -440,15 +440,15 @@ QStringList MinecraftInstance::javaArguments()
 
     args << "-Duser.language=en";
 
+    if (javaVersion.isModular() && traits().contains("legacySkins") && settings()->get("LegacySkinFix").toBool())
+        args << "--add-opens" << "java.base/java.net=ALL-UNNAMED";
+
     return args;
 }
 
-QString MinecraftInstance::getLauncher()
-{
-    auto profile = m_components->getProfile();
-
+QString MinecraftInstance::getLauncher() {
     // use legacy launcher if the traits are set
-    if (profile->getTraits().contains("legacyLaunch") || profile->getTraits().contains("alphaLaunch"))
+    if (traits().contains("legacyLaunch") || traits().contains("alphaLaunch"))
         return "legacy";
 
     return "standard";