CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tidy: Fix clang-tidy issues on files changed in this PR

Browse Source 
The checks used are roughly the same as the ones proposed in the
clang-tidy PR (except perhaps that I used modernize-* instead of listing
them individually,though I don't think this caused any readability
detriments).

In ModrinthModel.cpp and FlameModModel.cpp I ignored the
modernize-avoid-c-arrays one, mostly because making the sorts array an
std::array would most likely increase the code complexity because of the
virtual function. Aside from that, the static_cast warning from
Application.h was not dealt with, since it's not in this PR's scope.
This commit is contained in:
flow
2022-03-08 11:12:35 -03:00
parent b3c2a56ece
commit 8409aa2571
20 changed files with 86 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
launcher/ui/pages/modplatform/flame/FlameModPage.h
View File

@ -9,17 +9,17 @@ class FlameModPage : public ModPage {
public:
explicit FlameModPage(ModDownloadDialog* dialog, BaseInstance* instance);
virtual ~FlameModPage() = default;
~FlameModPage() override = default;
inline QString displayName() const override { return tr("CurseForge"); }
inline QIcon icon() const override { return APPLICATION->getThemedIcon("flame"); }
inline QString id() const override { return "curseforge"; }
inline QString helpPage() const override { return "Flame-platform"; }
inline auto displayName() const -> QString override { return tr("CurseForge"); }
inline auto icon() const -> QIcon override { return APPLICATION->getThemedIcon("flame"); }
inline auto id() const -> QString override { return "curseforge"; }
inline auto helpPage() const -> QString override { return "Flame-platform"; }
inline QString debugName() const override { return tr("Flame"); }
inline QString metaEntryBase() const override { return "FlameMods"; };
inline auto debugName() const -> QString override { return tr("Flame"); }
inline auto metaEntryBase() const -> QString override { return "FlameMods"; };
bool validateVersion(ModPlatform::IndexedVersion& ver, QString mineVer, QString loaderVer = "") const override;
auto validateVersion(ModPlatform::IndexedVersion& ver, QString mineVer, QString loaderVer = "") const -> bool override;
bool shouldDisplay() const override;
auto shouldDisplay() const -> bool override;
};