NOISSUE refactor Mod a bunch, get rid of dead code

application/dialogs/ModEditDialogCommon.cpp

@@ -1,40 +0,0 @@
-#include "ModEditDialogCommon.h"
-#include "CustomMessageBox.h"
-#include <QUrl>
-
-bool lastfirst(QModelIndexList &list, int &first, int &last)
-{
-    if (list.isEmpty())
-        return false;
-    first = last = list[0].row();
-    for (auto item : list)
-    {
-        int row = item.row();
-        if (row < first)
-            first = row;
-        if (row > last)
-            last = row;
-    }
-    return true;
-}
-
-void showWebsiteForMod(QWidget *parentDlg, Mod &m)
-{
-    QString url = m.homeurl();
-    if (url.size())
-    {
-        // catch the cases where the protocol is missing
-        if (!url.startsWith("http"))
-        {
-            url = "http://" + url;
-        }
-        DesktopServices::openUrl(url);
-    }
-    else
-    {
-        CustomMessageBox::selectable(
-            parentDlg, QObject::tr("How sad!"),
-            QObject::tr("The mod author didn't provide a website link for this mod."),
-            QMessageBox::Warning);
-    }
-}

application/dialogs/ModEditDialogCommon.h

@@ -1,9 +0,0 @@
-#pragma once
-#include <QModelIndex>
-#include <DesktopServices.h>
-#include <QWidget>
-#include <minecraft/Mod.h>
-
-bool lastfirst(QModelIndexList &list, int &first, int &last);
-
-void showWebsiteForMod(QWidget *parentDlg, Mod &m);