NOISSUE refactor Mod a bunch, get rid of dead code

application/CMakeLists.txt

@@ -159,8 +159,6 @@ SET(MULTIMC_SOURCES
     dialogs/IconPickerDialog.h
     dialogs/LoginDialog.cpp
     dialogs/LoginDialog.h
-    dialogs/ModEditDialogCommon.cpp
-    dialogs/ModEditDialogCommon.h
     dialogs/NewComponentDialog.cpp
     dialogs/NewComponentDialog.h
     dialogs/NewInstanceDialog.cpp

application/dialogs/ModEditDialogCommon.cpp

@@ -1,40 +0,0 @@
-#include "ModEditDialogCommon.h"
-#include "CustomMessageBox.h"
-#include <QUrl>
-
-bool lastfirst(QModelIndexList &list, int &first, int &last)
-{
-    if (list.isEmpty())
-        return false;
-    first = last = list[0].row();
-    for (auto item : list)
-    {
-        int row = item.row();
-        if (row < first)
-            first = row;
-        if (row > last)
-            last = row;
-    }
-    return true;
-}
-
-void showWebsiteForMod(QWidget *parentDlg, Mod &m)
-{
-    QString url = m.homeurl();
-    if (url.size())
-    {
-        // catch the cases where the protocol is missing
-        if (!url.startsWith("http"))
-        {
-            url = "http://" + url;
-        }
-        DesktopServices::openUrl(url);
-    }
-    else
-    {
-        CustomMessageBox::selectable(
-            parentDlg, QObject::tr("How sad!"),
-            QObject::tr("The mod author didn't provide a website link for this mod."),
-            QMessageBox::Warning);
-    }
-}

application/dialogs/ModEditDialogCommon.h

@@ -1,9 +0,0 @@
-#pragma once
-#include <QModelIndex>
-#include <DesktopServices.h>
-#include <QWidget>
-#include <minecraft/Mod.h>
-
-bool lastfirst(QModelIndexList &list, int &first, int &last);
-
-void showWebsiteForMod(QWidget *parentDlg, Mod &m);

application/pages/instance/ModFolderPage.cpp

@@ -24,7 +24,6 @@
 
 #include "MultiMC.h"
 #include "dialogs/CustomMessageBox.h"
-#include "dialogs/ModEditDialogCommon.h"
 #include <GuiUtil.h>
 #include "minecraft/SimpleModList.h"
 #include "minecraft/Mod.h"

application/pages/instance/VersionPage.cpp

@@ -27,7 +27,6 @@
 #include "dialogs/CustomMessageBox.h"
 #include "dialogs/VersionSelectDialog.h"
 #include "dialogs/NewComponentDialog.h"
-#include "dialogs/ModEditDialogCommon.h"
 
 #include "dialogs/ProgressDialog.h"
 #include <GuiUtil.h>

application/pages/instance/WorldListPage.cpp

@@ -17,7 +17,6 @@
 #include "ui_WorldListPage.h"
 #include "minecraft/WorldList.h"
 #include <DesktopServices.h>
-#include "dialogs/ModEditDialogCommon.h"
 #include <QEvent>
 #include <QMenu>
 #include <QKeyEvent>

application/widgets/MCModInfoFrame.cpp

@@ -40,7 +40,7 @@ void MCModInfoFrame::updateWithMod(Mod &m)
     else
         text = "<a href=\"" + m.homeurl() + "\">" + name + "</a>";
     if (!m.authors().isEmpty())
-        text += " by " + m.authors();
+        text += " by " + m.authors().join(", ");
 
     setModText(text);
 

application/widgets/ModListView.h

@@ -16,8 +16,6 @@
 #pragma once
 #include <QTreeView>
 
-class Mod;
-
 class ModListView: public QTreeView
 {
     Q_OBJECT

application/widgets/VersionListView.h

@@ -16,8 +16,6 @@
 #pragma once
 #include <QTreeView>
 
-class Mod;
-
 class VersionListView : public QTreeView
 {
     Q_OBJECT