fix: don't use forward-declared Ptr types in meta/
This would cause ODR violations when those headers were included in other places that also included stuff like "Version.h" (note the "meta/Version.h"), which can cause problems, especially in LTO. Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
@ -53,7 +53,7 @@ std::optional<QVector<QString>> AtlUserInteractionSupportImpl::chooseOptionalMod
|
||||
return optionalModDialog.getResult();
|
||||
}
|
||||
|
||||
QString AtlUserInteractionSupportImpl::chooseVersion(Meta::VersionListPtr vlist, QString minecraftVersion)
|
||||
QString AtlUserInteractionSupportImpl::chooseVersion(Meta::VersionList::Ptr vlist, QString minecraftVersion)
|
||||
{
|
||||
VersionSelectDialog vselect(vlist.get(), "Choose Version", m_parent, false);
|
||||
if (minecraftVersion != nullptr) {
|
||||
|
Reference in New Issue
Block a user