Catch C++ exceptions by const reference

Fixes #2277
This commit is contained in:
Charles Milette
2018-05-19 19:18:26 -04:00
parent b9fd381eee
commit 72c0002b45
22 changed files with 36 additions and 38 deletions

View File

@ -109,7 +109,7 @@ static std::unique_ptr <nbt::tag_compound> parseServersDat(const QString& filena
return std::move(pair.second);
}
catch(...)
catch (...)
{
return nullptr;
}
@ -125,7 +125,7 @@ static bool serializeServerDat(const QString& filename, nbt::tag_compound * leve
FS::write(filename, val);
return true;
}
catch(...)
catch (...)
{
return false;
}

View File

@ -200,7 +200,7 @@ bool VersionPage::reloadComponentList()
m_profile->reload(Net::Mode::Online);
return true;
}
catch (Exception &e)
catch (const Exception &e)
{
QMessageBox::critical(this, tr("Error"), e.cause());
return false;
@ -269,7 +269,7 @@ void VersionPage::on_moveUpBtn_clicked()
{
m_profile->move(currentRow(), ComponentList::MoveUp);
}
catch (Exception &e)
catch (const Exception &e)
{
QMessageBox::critical(this, tr("Error"), e.cause());
}
@ -282,7 +282,7 @@ void VersionPage::on_moveDownBtn_clicked()
{
m_profile->move(currentRow(), ComponentList::MoveDown);
}
catch (Exception &e)
catch (const Exception &e)
{
QMessageBox::critical(this, tr("Error"), e.cause());
}