CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: handling around disabled mods

Browse Source 
Don't update disabled mods to prevent mod duplication. Also, chop
filename in the metadata with a '.disabled'.

Signed-off-by: flow <flowlnlnln@gmail.com>
This commit is contained in:
flow
2022-06-20 08:55:35 -03:00
parent a7648d60ce
commit 5f75e531e6
5 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
launcher/ui/dialogs/ModUpdateDialog.cpp
View File

@ -62,8 +62,10 @@ void ModUpdateDialog::checkCandidates()
// Report failed metadata generation
if (!m_failed_metadata.empty()) {
QString text;
for (const auto& mod : m_failed_metadata) {
text += tr("Mod name: %1<br>File name: %2<br><br>").arg(mod.name(), mod.fileinfo().fileName());
for (const auto& failed : m_failed_metadata) {
const auto& mod = std::get<0>(failed);
const auto& reason = std::get<1>(failed);
text += tr("Mod name: %1<br>File name: %2<br>Reason: %3<br><br>").arg(mod.name(), mod.fileinfo().fileName(), reason);
}
ScrollMessageBox message_dialog(m_parent, tr("Metadata generation failed"),
@ -316,7 +318,9 @@ void ModUpdateDialog::onMetadataFailed(Mod& mod, bool try_others, ModPlatform::P
m_second_try_metadata->addTask(task);
} else {
m_failed_metadata.push_back(mod);
QString reason { tr("Didn't find a valid version on the selected mod provider(s)") };
m_failed_metadata.emplace_back(mod, reason);
}
}

2
launcher/ui/dialogs/ModUpdateDialog.h
View File

@ -50,7 +50,7 @@ class ModUpdateDialog final : public ReviewMessageBox {
std::list<Mod> m_flame_to_update;
SequentialTask* m_second_try_metadata;
std::list<Mod> m_failed_metadata;
std::list<std::tuple<Mod, QString>> m_failed_metadata;
std::list<std::tuple<Mod, QString, QUrl>> m_failed_check_update;
QHash<QString, ModDownloadTask*> m_tasks;