Fix crash when aborting instance import
Also turned a loop var into a reference to avoid copies on each iteration
This commit is contained in:
parent
3ff26d5cfe
commit
48e20cb5f7
@ -72,7 +72,8 @@ InstanceImportTask::InstanceImportTask(const QUrl sourceUrl, QWidget* parent)
|
|||||||
|
|
||||||
bool InstanceImportTask::abort()
|
bool InstanceImportTask::abort()
|
||||||
{
|
{
|
||||||
m_filesNetJob->abort();
|
if (m_filesNetJob)
|
||||||
|
m_filesNetJob->abort();
|
||||||
m_extractFuture.cancel();
|
m_extractFuture.cancel();
|
||||||
|
|
||||||
return false;
|
return false;
|
||||||
@ -386,7 +387,7 @@ void InstanceImportTask::processFlame()
|
|||||||
{
|
{
|
||||||
auto results = m_modIdResolver->getResults();
|
auto results = m_modIdResolver->getResults();
|
||||||
m_filesNetJob = new NetJob(tr("Mod download"), APPLICATION->network());
|
m_filesNetJob = new NetJob(tr("Mod download"), APPLICATION->network());
|
||||||
for(auto result: results.files)
|
for(const auto& result: results.files)
|
||||||
{
|
{
|
||||||
QString filename = result.fileName;
|
QString filename = result.fileName;
|
||||||
if(!result.required)
|
if(!result.required)
|
||||||
|
Loading…
Reference in New Issue
Block a user