Revert "nix: revert overlay changes and add conditionals to derivation for flake build"

flake.nix

@@ -21,13 +21,14 @@
         packages = {
           polymc = pkgs.libsForQt5.callPackage ./packages/nix/polymc {
             inherit self;
-            isFlakeBuild = true;
             submoduleQuazip = quazip;
             submoduleNbt = libnbtplusplus;
           };
         };
 
-        overlay = import ./packages/nix/overlay.nix {};
+        overlay = import ./packages/nix/overlay.nix {
+          inherit self quazip libnbtplusplus;
+        };
 
         apps = {
           polymc = flake-utils.lib.mkApp {

packages/nix/overlay.nix

@@ -1,3 +1,9 @@
+{ self, quazip, libnbtplusplus }:
+
 final: prev: rec {
-  polymc = prev.libsForQt5.callPackage ./polymc {};
+  polymc = prev.libsForQt5.callPackage ./polymc {
+    inherit self;
+    submoduleQuazip = quazip;
+    submoduleNbt = libnbtplusplus;
+  };
 }

packages/nix/polymc/default.nix

@@ -15,10 +15,9 @@
 , qtbase
 , libGL
 # submodules
-, isFlakeBuild ? false
+, self
-, self ? ""
+, submoduleNbt
-, submoduleNbt ? ""
+, submoduleQuazip
-, submoduleQuazip ? ""
 }:
 
 let
@@ -35,26 +34,19 @@ in
 
 mkDerivation rec {
   pname = "polymc";
-  version = if isFlakeBuild then "nightly" else "1.0.4";
+  version = "nightly";
 
-  src = if isFlakeBuild then lib.cleanSource self
+  src = lib.cleanSource self;
-    else fetchFromGitHub {
-    owner = "PolyMC";
-    repo = "PolyMC";
-    rev = "${version}";
-    sha256 = "sha256-8aya0KfV9F+i2qBpweWcR9hwyTSQkqn2wHdtkCEeNvk=";
-    fetchSubmodules = true;
-  };
 
   nativeBuildInputs = [ cmake file makeWrapper ];
   buildInputs = [ qtbase jdk8 zlib ];
 
-  postUnpack = if isFlakeBuild then ''
+  postUnpack = ''
     mkdir source/libraries/{libnbtplusplus,quazip}
     cp -a ${submoduleNbt}/* source/libraries/libnbtplusplus
     cp -a ${submoduleQuazip}/* source/libraries/quazip
     chmod a+r+w source/libraries/{libnbtplusplus,quazip}/*
-  '' else "";
+  '';
 
   cmakeFlags = [
     "-DLauncher_LAYOUT=lin-system"