Fix launcher part for legacy in onesix.

depends/launcher/CMakeLists.txt

@@ -18,7 +18,7 @@ set(SRC
 	# The launcher has to be there for silly FML/Forge relauncher.
 	net/minecraft/Launcher.java
 	org/multimc/legacy/LegacyLauncher.java
-	org/multimc/legacy/LegacyFrame.java
+	org/multimc/LegacyFrame.java
 
 	# onesix launcher
 	org/multimc/onesix/OneSixLauncher.java

depends/launcher/org/multimc/LegacyFrame.java

@@ -1,4 +1,4 @@
-package org.multimc.legacy;/*
+package org.multimc;/*
  * Copyright 2012-2014 MultiMC Contributors
  *
  * Licensed under the Apache License, Version 2.0 (the "License");

depends/launcher/org/multimc/legacy/LegacyLauncher.java

@@ -14,10 +14,7 @@ package org.multimc.legacy;/*
  * limitations under the License.
  */
 
-import org.multimc.Launcher;
+import org.multimc.*;
-import org.multimc.NotFoundException;
-import org.multimc.ParamBucket;
-import org.multimc.Utils;
 
 import java.applet.Applet;
 import java.awt.*;

depends/launcher/org/multimc/onesix/OneSixLauncher.java

@@ -17,7 +17,9 @@ package org.multimc.onesix;
 
 import org.multimc.*;
 
+import java.applet.Applet;
 import java.io.File;
+import java.awt.*;
 import java.io.IOException;
 import java.lang.reflect.Field;
 import java.lang.reflect.InvocationTargetException;
@@ -30,20 +32,27 @@ import java.util.List;
 
 public class OneSixLauncher implements Launcher
 {
-	@Override
+	// parameters, separated from ParamBucket
-	public int launch(ParamBucket params)
+	private List<String> libraries;
-	{
+	private List<String> extlibs;
-		// get and process the launch script params
+	private List<String> mcparams;
-		List<String> libraries;
+	private List<String> mods;
-		List<String> extlibs;
+	private List<String> traits;
-		List<String> mcparams;
+	private String mainClass;
-		List<String> mods;
+	private String natives;
-		List<String> traits;
+	private String userName, sessionId;
-		String mainClass;
+	private String windowTitle;
-		String natives;
+	private String windowParams;
-		final String windowTitle;
+	
-		String windowParams;
+	// secondary parameters
-		try
+	private Dimension winSize;
+	private boolean maximize;
+	private String cwd;
+	
+	// the much abused system classloader, for convenience (for further abuse)
+	private ClassLoader cl;
+
+	private void processParams(ParamBucket params) throws NotFoundException
 	{
 		libraries = params.all("cp");
 		extlibs = params.all("ext");
@@ -53,26 +62,31 @@ public class OneSixLauncher implements Launcher
 		traits = params.allSafe("traits", new ArrayList<String>());
 		natives = params.first("natives");
 
-			windowTitle = params.first("windowTitle");
+		userName = params.first("userName");
-			// windowParams = params.first("windowParams");
+		sessionId = params.first("sessionId");
-		} catch (NotFoundException e)
+		windowTitle = params.firstSafe("windowTitle", "Minecraft");
+		windowParams = params.firstSafe("windowParams", "854x480");
+		
+		cwd = System.getProperty("user.dir");
+		winSize = new Dimension(854, 480);
+		maximize = false;
+
+		String[] dimStrings = windowParams.split("x");
+
+		if (windowParams.equalsIgnoreCase("max"))
 		{
-			System.err.println("Not enough arguments.");
+			maximize = true;
-			e.printStackTrace(System.err);
+		}
-			return -1;
+		else if (dimStrings.length == 2)
+		{
+			try
+			{
+				winSize = new Dimension(Integer.parseInt(dimStrings[0]), Integer.parseInt(dimStrings[1]));
+			} catch (NumberFormatException ignored) {}
+		}
 	}
 	
-		List<String> allJars = new ArrayList<String>();
+	private void printStats()
-		allJars.addAll(mods);
-		allJars.addAll(libraries);
-
-		if(!Utils.addToClassPath(allJars))
-		{
-			System.err.println("Halting launch due to previous errors.");
-			return -1;
-		}
-
-		// print the pretty things
 	{
 		Utils.log("Main Class:");
 		Utils.log("  " + mainClass);
@@ -82,6 +96,10 @@ public class OneSixLauncher implements Launcher
 		Utils.log("  " + natives);
 		Utils.log();
 
+		Utils.log("Traits:");
+		Utils.log("  " + traits);
+		Utils.log();
+
 		Utils.log("Libraries:");
 		for (String s : libraries)
 		{
@@ -104,43 +122,66 @@ public class OneSixLauncher implements Launcher
 		Utils.log();
 	}
 	
-		// set up the natives path(s).
+	int legacyLaunch()
-		Utils.log("Preparing native libraries...");
-		String property = System.getProperty("os.arch");
-		boolean is_64 = property.equalsIgnoreCase("x86_64") || property.equalsIgnoreCase("amd64");
-		for(String extlib: extlibs)
 	{
+		// Get the Minecraft Class and set the base folder
+		Class<?> mc;
 		try
 		{
-				String cleanlib = extlib.replace("${arch}", is_64 ? "64" : "32");
+			mc = cl.loadClass(mainClass);
-				File cleanlibf = new File(cleanlib);
+
-				Utils.log("Extracting " + cleanlibf.getName());
+			Field f = Utils.getMCPathField(mc);
-				Utils.unzip(cleanlibf, new File(natives));
+
-			} catch (IOException e)
+			if (f == null)
 			{
-				System.err.println("Failed to extract native library:");
+				System.err.println("Could not find Minecraft path field. Launch failed.");
-				e.printStackTrace(System.err);
 				return -1;
 			}
-		}
-		Utils.log();
 
-		System.setProperty("java.library.path", natives);
+			f.setAccessible(true);
-		Field fieldSysPath;
+			f.set(null, new File(cwd));
-		try
-		{
-			fieldSysPath = ClassLoader.class.getDeclaredField("sys_paths");
-			fieldSysPath.setAccessible( true );
-			fieldSysPath.set( null, null );
 		} catch (Exception e)
 		{
-			System.err.println("Failed to set the native library path:");
+			System.err.println("Could not set base folder. Failed to find/access Minecraft main class:");
 			e.printStackTrace(System.err);
 			return -1;
 		}
 
+		System.setProperty("minecraft.applet.TargetDirectory", cwd);
+
+		String[] mcArgs = new String[2];
+		mcArgs[0] = userName;
+		mcArgs[1] = sessionId;
+
+		Utils.log("Launching with applet wrapper...");
+		try
+		{
+			Class<?> MCAppletClass = cl.loadClass("net.minecraft.client.MinecraftApplet");
+			Applet mcappl = (Applet) MCAppletClass.newInstance();
+			LegacyFrame mcWindow = new LegacyFrame(windowTitle);
+			mcWindow.start(mcappl, userName, sessionId, winSize, maximize);
+		} catch (Exception e)
+		{
+			Utils.log("Applet wrapper failed:", "Error");
+			e.printStackTrace(System.err);
+			Utils.log();
+			Utils.log("Falling back to compatibility mode.");
+			try
+			{
+				mc.getMethod("main", String[].class).invoke(null, (Object) mcArgs);
+			} catch (Exception e1)
+			{
+				Utils.log("Failed to invoke the Minecraft main class:", "Fatal");
+				e1.printStackTrace(System.err);
+				return -1;
+			}
+		}
+		return 0;
+	}
+	
+	int launchWithMainClass()
+	{
 		// Get the Minecraft Class.
-		final ClassLoader cl = ClassLoader.getSystemClassLoader();
 		Class<?> mc;
 		try
 		{
@@ -164,7 +205,108 @@ public class OneSixLauncher implements Launcher
 			return -1;
 		}
 		
-		// FIXME: works only on linux, we need a better solution
+		// init params for the main method to chomp on.
+		String[] paramsArray = mcparams.toArray(new String[mcparams.size()]);
+		try
+		{
+			// static method doesn't have an instance
+			meth.invoke(null, (Object) paramsArray);
+		} catch (Exception e)
+		{
+			System.err.println("Failed to start Minecraft:");
+			e.printStackTrace(System.err);
+			return -1;
+		}
+		return 0;
+	}
+	
+	@Override
+	public int launch(ParamBucket params)
+	{
+		// get and process the launch script params
+		try
+		{
+			processParams(params);
+		} catch (NotFoundException e)
+		{
+			System.err.println("Not enough arguments.");
+			e.printStackTrace(System.err);
+			return -1;
+		}
+
+		// do some horrible black magic with the classpath
+		{
+			List<String> allJars = new ArrayList<String>();
+			allJars.addAll(mods);
+			allJars.addAll(libraries);
+
+			if(!Utils.addToClassPath(allJars))
+			{
+				System.err.println("Halting launch due to previous errors.");
+				return -1;
+			}
+		}
+
+		// print the pretty things
+		printStats();
+
+		// extract native libs (depending on platform here... java!)
+		Utils.log("Preparing native libraries...");
+		String property = System.getProperty("os.arch");
+		boolean is_64 = property.equalsIgnoreCase("x86_64") || property.equalsIgnoreCase("amd64");
+		for(String extlib: extlibs)
+		{
+			try
+			{
+				String cleanlib = extlib.replace("${arch}", is_64 ? "64" : "32");
+				File cleanlibf = new File(cleanlib);
+				Utils.log("Extracting " + cleanlibf.getName());
+				Utils.unzip(cleanlibf, new File(natives));
+			} catch (IOException e)
+			{
+				System.err.println("Failed to extract native library:");
+				e.printStackTrace(System.err);
+				return -1;
+			}
+		}
+		Utils.log();
+		
+		// set the native libs path... the brute force way
+		try
+		{
+			System.setProperty("java.library.path", natives);
+			System.setProperty("org.lwjgl.librarypath", natives);
+			System.setProperty("net.java.games.input.librarypath", natives);
+			// by the power of reflection, initialize native libs again. DIRTY!
+			// this is SO BAD. imagine doing that to ld
+			Field fieldSysPath = ClassLoader.class.getDeclaredField("sys_paths");
+			fieldSysPath.setAccessible( true );
+			fieldSysPath.set( null, null );
+		} catch (Exception e)
+		{
+			System.err.println("Failed to set the native library path:");
+			e.printStackTrace(System.err);
+			return -1;
+		}
+		
+		// grab the system classloader and ...
+		cl = ClassLoader.getSystemClassLoader();
+		
+		if (traits.contains("legacyLaunch"))
+		{
+			// legacy launch uses the applet wrapper
+			return legacyLaunch();
+		}
+		else
+		{
+			// normal launch just calls main()
+			return launchWithMainClass();
+		}
+	}
+}
+
+
+// FIXME: works only on linux, we need a better solution
 /*
 		final java.nio.ByteBuffer[] icons = IconLoader.load("icon.png");
 		new Thread() {
@@ -209,17 +351,3 @@ public class OneSixLauncher implements Launcher
 		}
 		.start();
 */
-		// start Minecraft
-		String[] paramsArray = mcparams.toArray(new String[mcparams.size()]); // init params accordingly
-		try
-		{
-			meth.invoke(null, (Object) paramsArray); // static method doesn't have an instance
-		} catch (Exception e)
-		{
-			System.err.println("Failed to start Minecraft:");
-			e.printStackTrace(System.err);
-			return -1;
-		}
-		return 0;
-	}
-}

logic/OneSixInstance.cpp

@@ -200,6 +200,8 @@ bool OneSixInstance::prepareForLaunch(AuthSessionPtr account, QString &launchScr
 	auto version = d->version;
 	if (!version)
 		return nullptr;
+
+	// libraries and class path.
 	{
 		auto libs = version->getActiveNormalLibs();
 		for (auto lib : libs)
@@ -223,15 +225,31 @@ bool OneSixInstance::prepareForLaunch(AuthSessionPtr account, QString &launchScr
 	}
 	launchScript += "mainClass " + version->mainClass + "\n";
 
+	// generic minecraft params
 	for (auto param : processMinecraftArgs(account))
 	{
 		launchScript += "param " + param + "\n";
 	}
 
-	// Set the width and height for 1.6 instances
+	// window size, title and state, legacy
+	{
+		QString windowParams;
+		if (settings().get("LaunchMaximized").toBool())
+			windowParams = "max";
+		else
+			windowParams = QString("%1x%2")
+							   .arg(settings().get("MinecraftWinWidth").toInt())
+							   .arg(settings().get("MinecraftWinHeight").toInt());
+		launchScript += "windowTitle " + windowTitle() + "\n";
+		launchScript += "windowParams " + windowParams + "\n";
+	}
+	
+	// window size, title and state, onesix
+	{
 		bool maximize = settings().get("LaunchMaximized").toBool();
 		if (maximize)
 		{
+			// FIXME: there is no good way to maximize the minecraft window in onesix.
 			// this is probably a BAD idea
 			// launchScript += "param --fullscreen\n";
 		}
@@ -242,17 +260,29 @@ bool OneSixInstance::prepareForLaunch(AuthSessionPtr account, QString &launchScr
 			launchScript +=
 				"param --height\nparam " + settings().get("MinecraftWinHeight").toString() + "\n";
 		}
+	}
+	
+	// legacy auth
+	{
+		launchScript += "userName " + session->player_name + "\n";
+		launchScript += "sessionId " + session->session + "\n";
+	}
+
+	// native libraries (mostly LWJGL)
+	{
 		QDir natives_dir(PathCombine(instanceRoot(), "natives/"));
-	launchScript += "windowTitle " + windowTitle() + "\n";
 		for (auto native : version->getActiveNativeLibs())
 		{
 			QFileInfo finfo(PathCombine("libraries", native->storagePath()));
 			launchScript += "ext " + finfo.absoluteFilePath() + "\n";
 		}
 		launchScript += "natives " + natives_dir.absolutePath() + "\n";
+	}
+	
+	// traits. including legacyLaunch and others ;)
 	for (auto trait : version->traits)
 	{
-		launchScript += "trait " + trait + "\n";
+		launchScript += "traits " + trait + "\n";
 	}
 	launchScript += "launcher onesix\n";
 	return true;