refactor: improve code readability

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
This commit is contained in:
Sefa Eyeoglu 2022-10-01 22:16:07 +02:00
parent 61f938546d
commit 24060291c8
No known key found for this signature in database
GPG Key ID: C10411294912A422

View File

@ -153,45 +153,53 @@ QVariant InstanceList::data(const QModelIndex& index, int role) const {
} }
const InstancePtr inst = m_instances[index.row()]; const InstancePtr inst = m_instances[index.row()];
switch (static_cast<Column>(index.column())) { switch (role) {
case IconColumn: case Qt::DecorationRole: {
if (role == Qt::DecorationRole) { if (index.column() == IconColumn)
return inst->iconKey(); return inst->iconKey();
}
break; break;
}
case Qt::DisplayRole: {
switch (index.column()) {
case NameColumn: case NameColumn:
if (role == Qt::DisplayRole || role == Qt::EditRole)
return inst->name(); return inst->name();
if (role == Qt::AccessibleTextRole) case GameVersionColumn:
return tr("%1 Instance").arg(inst->name());
if (role == Qt::ToolTipRole)
return inst->instanceRoot();
break;
case GameVersionColumn: {
if (role == Qt::DisplayRole)
return inst->getMainVersion(); return inst->getMainVersion();
case PlayTimeColumn:
return Time::prettifyDuration(inst->totalTimePlayed());
case LastPlayedColumn:
return QDateTime::fromMSecsSinceEpoch(inst->lastLaunch());
}
break; break;
} }
case PlayTimeColumn: {
QString foo = Time::prettifyDuration(inst->totalTimePlayed()); case Qt::ToolTipRole: {
if (role == Qt::DisplayRole) switch (index.column()) {
return foo; case NameColumn:
if (role == Qt::ToolTipRole) return inst->instanceRoot();
return tr("Total played for %1").arg(foo); case GameVersionColumn:
return inst->getMainVersion();
case PlayTimeColumn:
return tr("Total played for %1").arg(Time::prettifyDuration(inst->totalTimePlayed()));
case LastPlayedColumn:
return tr("Last played for %1").arg(Time::prettifyDuration(inst->lastTimePlayed()));
}
break; break;
} }
case LastPlayedColumn: {
QString foo = Time::prettifyDuration(inst->lastTimePlayed()); case Qt::EditRole: {
QDateTime bar = QDateTime::fromMSecsSinceEpoch(inst->lastLaunch()); if (index.column() == NameColumn)
if (role == Qt::DisplayRole) return data(index, Qt::DisplayRole);
return bar;
if (role == Qt::ToolTipRole)
return tr("Last played for %1").arg(foo);
break; break;
} }
default:
case Qt::AccessibleTextRole: {
if (index.column() == NameColumn)
return tr("%1 Instance").arg(inst->name());
break; break;
} }
}
return QVariant(); return QVariant();
} }