CactiChameleon9/PrismLauncher
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Qt can handle const& in signals and slots

Browse Source 
While most Qt types cna use implicit data sharing
pasing our own structs means copies. const& ensure
it's only copied as needed by Qt.

Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com>
This commit is contained in:
Rachel Powers
2023-04-07 19:44:57 -07:00
parent a80b425551
commit 236764adf6
6 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
launcher/ui/dialogs/ProgressDialog.cpp
View File

@ -206,14 +206,14 @@ void ProgressDialog::changeStatus(const QString& status)
updateSize();
}
void ProgressDialog::addTaskProgress(TaskStepProgress* progress)
void ProgressDialog::addTaskProgress(TaskStepProgress const& progress)
{
SubTaskProgressBar* task_bar = new SubTaskProgressBar(this);
taskProgress.insert(progress->uid, task_bar);
taskProgress.insert(progress.uid, task_bar);
ui->taskProgressLayout->addWidget(task_bar);
}
void ProgressDialog::changeStepProgress(TaskStepProgress task_progress)
void ProgressDialog::changeStepProgress(TaskStepProgress const& task_progress)
{
m_is_multi_step = true;
if(ui->taskProgressScrollArea->isHidden()) {
@ -222,7 +222,7 @@ void ProgressDialog::changeStepProgress(TaskStepProgress task_progress)
}
if (!taskProgress.contains(task_progress.uid))
addTaskProgress(&task_progress);
addTaskProgress(task_progress);
auto task_bar = taskProgress.value(task_progress.uid);

4
launcher/ui/dialogs/ProgressDialog.h
View File

@ -80,7 +80,7 @@ slots:
void changeStatus(const QString &status);
void changeProgress(qint64 current, qint64 total);
void changeStepProgress(TaskStepProgress task_progress);
void changeStepProgress(TaskStepProgress const& task_progress);
private
@ -93,7 +93,7 @@ protected:
private:
bool handleImmediateResult(QDialog::DialogCode &result);
void addTaskProgress(TaskStepProgress* progress);
void addTaskProgress(TaskStepProgress const& progress);
private:
Ui::ProgressDialog *ui;