I could use rvalue references and fix my brain fart, but i think regular references are more readable and safer here.

Signed-off-by: TheKodeToad <TheKodeToad@proton.me>
This commit is contained in:
TheKodeToad 2023-06-22 12:56:47 +01:00
parent 94510edd72
commit 1f16380efc

View File

@ -32,14 +32,14 @@
class LoaderPage : public VersionSelectWidget, public BasePage { class LoaderPage : public VersionSelectWidget, public BasePage {
public: public:
LoaderPage(const QString&& id, LoaderPage(const QString& id,
const QString&& icon, const QString& icon,
const QString&& name, const QString& name,
// "lightweight" loaders are independent to any game version // "lightweight" loaders are independent to any game version
const bool lightweight, const bool lightweight,
const std::shared_ptr<PackProfile> profile, const std::shared_ptr<PackProfile> profile,
QWidget* parent = nullptr) QWidget* parent = nullptr)
: VersionSelectWidget(parent), m_id(std::move(id)), m_icon(std::move(icon)), m_name(std::move(name)) : VersionSelectWidget(parent), m_id(id), m_icon(icon), m_name(name)
{ {
const QString minecraftVersion = profile->getComponentVersion("net.minecraft"); const QString minecraftVersion = profile->getComponentVersion("net.minecraft");
setEmptyString(tr("No versions are currently available for Minecraft %1").arg(minecraftVersion)); setEmptyString(tr("No versions are currently available for Minecraft %1").arg(minecraftVersion));