Fixed icons
Also having a mod loader is now enforced
This commit is contained in:
@ -349,25 +349,34 @@ void ModFolderPage::on_actionInstall_mods_triggered()
|
||||
if(!m_controlsEnabled) {
|
||||
return;
|
||||
}
|
||||
ModDownloadDialog mdownload(m_mods, this);
|
||||
mdownload.exec();
|
||||
ModDownloadTask * task = mdownload.getTask();
|
||||
if(task){
|
||||
connect(task, &Task::failed, [this](QString reason)
|
||||
{
|
||||
CustomMessageBox::selectable(this, tr("Error"), reason, QMessageBox::Critical)->show();
|
||||
});
|
||||
connect(task, &Task::succeeded, [this, task]()
|
||||
{
|
||||
QStringList warnings = task->warnings();
|
||||
if(warnings.count())
|
||||
{
|
||||
CustomMessageBox::selectable(this, tr("Warnings"), warnings.join('\n'), QMessageBox::Warning)->show();
|
||||
}
|
||||
});
|
||||
ProgressDialog loadDialog(this);
|
||||
loadDialog.setSkipButton(true, tr("Abort"));
|
||||
loadDialog.execWithTask(task);
|
||||
if(m_inst->typeName() != "Minecraft"){
|
||||
return; //this is a null instance or a legacy instance
|
||||
}
|
||||
bool hasFabric = !((MinecraftInstance *)m_inst)->getPackProfile()->getComponentVersion("net.fabricmc.fabric-loader").isEmpty();
|
||||
bool hasForge = !((MinecraftInstance *)m_inst)->getPackProfile()->getComponentVersion("net.minecraftforge").isEmpty();
|
||||
if (!hasFabric && !hasForge) {
|
||||
QMessageBox::critical(this,tr("Error"),tr("Please install a mod loader first !"));
|
||||
return;
|
||||
}
|
||||
ModDownloadDialog mdownload(m_mods, this, m_inst);
|
||||
if(mdownload.exec()) {
|
||||
ModDownloadTask *task = mdownload.getTask();
|
||||
if (task) {
|
||||
connect(task, &Task::failed, [this](QString reason) {
|
||||
CustomMessageBox::selectable(this, tr("Error"), reason, QMessageBox::Critical)->show();
|
||||
});
|
||||
connect(task, &Task::succeeded, [this, task]() {
|
||||
QStringList warnings = task->warnings();
|
||||
if (warnings.count()) {
|
||||
CustomMessageBox::selectable(this, tr("Warnings"), warnings.join('\n'),
|
||||
QMessageBox::Warning)->show();
|
||||
}
|
||||
});
|
||||
ProgressDialog loadDialog(this);
|
||||
loadDialog.setSkipButton(true, tr("Abort"));
|
||||
loadDialog.execWithTask(task);
|
||||
m_mods->update();
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
@ -100,7 +100,7 @@ void ListModel::requestLogo(QString logo, QString url)
|
||||
}
|
||||
|
||||
MetaEntryPtr entry = APPLICATION->metacache()->resolveEntry("ModrinthPacks", QString("logos/%1").arg(logo.section(".", 0, 0)));
|
||||
NetJob *job = new NetJob(QString("Modrinth Icon Download %1").arg(logo), APPLICATION->network());
|
||||
auto job = new NetJob(QString("Modrinth Icon Download %1").arg(logo), APPLICATION->network());
|
||||
job->addNetAction(Net::Download::makeCached(QUrl(url), entry));
|
||||
|
||||
auto fullPath = entry->getFullPath();
|
||||
@ -119,7 +119,6 @@ void ListModel::requestLogo(QString logo, QString url)
|
||||
});
|
||||
|
||||
job->start();
|
||||
|
||||
m_loadingLogos.append(logo);
|
||||
}
|
||||
|
||||
|
@ -9,9 +9,11 @@
|
||||
#include "InstanceImportTask.h"
|
||||
#include "ModrinthModel.h"
|
||||
#include "ModDownloadTask.h"
|
||||
#include "ui/pages/instance/ModFolderPage.h"
|
||||
#include "minecraft/PackProfile.h"
|
||||
|
||||
ModrinthPage::ModrinthPage(ModDownloadDialog* dialog, QWidget *parent)
|
||||
: QWidget(parent), ui(new Ui::ModrinthPage), dialog(dialog)
|
||||
ModrinthPage::ModrinthPage(ModDownloadDialog *dialog, BaseInstance *instance)
|
||||
: QWidget(dialog), ui(new Ui::ModrinthPage), dialog(dialog), m_instance(instance)
|
||||
{
|
||||
ui->setupUi(this);
|
||||
connect(ui->searchButton, &QPushButton::clicked, this, &ModrinthPage::triggerSearch);
|
||||
|
@ -38,7 +38,7 @@ class ModrinthPage : public QWidget, public BasePage
|
||||
Q_OBJECT
|
||||
|
||||
public:
|
||||
explicit ModrinthPage(ModDownloadDialog* dialog, QWidget *parent = 0);
|
||||
explicit ModrinthPage(ModDownloadDialog *dialog, BaseInstance *instance);
|
||||
virtual ~ModrinthPage();
|
||||
virtual QString displayName() const override
|
||||
{
|
||||
@ -77,4 +77,5 @@ private:
|
||||
Modrinth::IndexedPack current;
|
||||
|
||||
QString selectedVersion;
|
||||
BaseInstance *m_instance;
|
||||
};
|
||||
|
Reference in New Issue
Block a user